Test wildcard pattern in build_pr.sh (part 2)#3186
Merged
colleenmcginnis merged 2 commits intomasterfrom Mar 13, 2025
Merged
Conversation
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
colleenmcginnis
changed the title
build_pr.sh (part 2)
colleenmcginnis
commented
Mar 13, 2025
bmorelli25
approved these changes
Mar 13, 2025
Member
bmorelli25
left a comment
bmorelli25
left a comment
There was a problem hiding this comment.
Good idea! Let's try it out.
reakaleek
pushed a commit
that referenced
this pull request
Mar 28, 2025
* try wrapping in quotes * Update .buildkite/scripts/build_pr.sh
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test out using a wildcard pattern in
build_pr.shto determine when we should run the AsciiDoc preview build. If this works, it will be an imperfect solution because it would not build if only an image was updated in a PR, but that might be ok. 🤷This PR builds on #3182 by wrapping the path in quotes. It looks like that could be necessary in some environments when using wildcards, and since
"origin/$GITHUB_PR_TARGET_BRANCH"is wrapped in quotes even though it works without them on my local machine... I'm hoping this is the trick. I also expanded the matching pattern to include any AsciiDoc file. (I'm not sure if there's a better way to test this.)To test this we'll have to:
Then come back here and update the other repos.
@bmorelli25 what do you think about this approach?